[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG97d6e8e0f374: [clangd] Helper for getting nested namespace qualification (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

merge_guards_bot added a comment. Build result: pass - 60224 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet updated this revision to Diff 230423. kadircet marked 14 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69608/new/ https://reviews.llvm.org/D69608 Files: clang-tools-e

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet marked 14 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:330 + [&](NestedNameSpecifier *NNS) { +return llvm::any_of( +VisibleNamesp

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM when the comments are addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69608/new/ https://reviews.llvm.org/D69608 _

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

ilya-biryukov added a comment. Just NITs about various comments and requests to optimize the code a bit. The code itself LG, thanks! Comment at: clang-tools-extra/clangd/AST.cpp:77 +llvm::DenseSet +getUsingNamespceDirectives(const DeclContext *DestContext, +

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet updated this revision to Diff 230211. kadircet marked 4 inline comments as done. kadircet added a comment. - Add support for non-namespace decl contexts. - Add an overload for "textual namespace" handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:281 + +auto *NSD = llvm::dyn_cast(Context); +assert(NSD && "Non-namespace decl context found."); NIT: `dyn_cast` + `assert` are equivalent to a single `llvm::cast` ===

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Introduce a new helper for getting minimally required qualifiers necessary to spell a name at a point in a given De