[PATCH] D69620: Add AIX assembler support

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebfab709583: Add AIX assembler support (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231712. stevewan added a comment. State in the comment the expectation to driver in handling assembler source input when invoking as(1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor change request to a comment. Thanks. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input files."); +

[PATCH] D69620: Add AIX assembler support

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input files."); + const InputInfo = Inputs[0];

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231579. stevewan added a comment. Herald added subscribers: kbarton, nemanjai. Add more input file handling 1. Check if the input file is of type Filename or Nothing, throw assertion otherwise. 2. Add a test case to verify the correct behaviour of

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:70 + const InputInfo = Inputs[0]; + if (II.isFilename()) +CmdArgs.push_back(II.getFilename()); Should is also be checked as being either a filename or "nothing"?

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input files."); + const InputInfo = Inputs[0]; `llvm_unreachable` is not the right solution if

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231557. stevewan added a comment. Correct a typo in a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://reviews.llvm.org/D69620 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D69620: Add AIX assembler support

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Other than minor nit, LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input file."); + const

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; stevewan

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231000. stevewan marked 12 inline comments as done. stevewan added a comment. Remove claimNoWarnArgs, limit the number of input files, and add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:37 + + // Specify the mode in which the as command operates. + if (IsArch32Bit) { Refer to the other comment regarding confusion of "as" with the English word.

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; stevewan

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 230360. stevewan marked an inline comment as done. stevewan added a comment. Add "-u" to accept undefined symbol as extern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/

[PATCH] D69620: Add AIX assembler support

stevewan marked 4 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; Xiangling_L

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:45 + // Acccept any mixture of instructions. + CmdArgs.push_back("-many"); + Xiangling_L wrote: > GCC invokes system assembler also with

[PATCH] D69620: Add AIX assembler support

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:26 + + bool hasIntegratedCPP() const override { return false; } + stevewan wrote: > Xiangling_L wrote: > > I saw a lot of other target also set `hasIntegratedCPP()` as false, but I >

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:26 + + bool hasIntegratedCPP() const override { return false; } + Xiangling_L wrote: > I saw a lot of other target also set

[PATCH] D69620: Add AIX assembler support

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; The definition of `claimNoWarnArgs` is to suppress

[PATCH] D69620: Add AIX assembler support

stevewan created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. This is a follow on patch to D68340 . Given the AIX toolchain skeleton and system linker support introduced in D68340 ,