[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. @hoyFB wrote: > @ormris I'd like to follow up on this. We had a similar change internally > which led up to some gains when combined with SPGO, and we'd like to help > move forward with this patch here. Would you mind sharing the plan or > progress on your side?

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

hoyFB added a comment. In D69732#1771950 , @ormris wrote: > I've done testing with the following global parameters. > > - The base for the branch is llvmorg-10-init-8655-g94a4a2c97f8 > - Used llvm, clang, lld, and llvm-ar from this branch. > - The sqlite

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson added a comment. In D69732#1784511 , @wristow wrote: > >> Given the performance improvements here, I'd like to develop this patch > >> further. > > > > In D69732#1784290 , @ormris wrote: > > //Ping//

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wristow added a comment. >> Given the performance improvements here, I'd like to develop this patch >> further. > > In D69732#1784290 , @ormris wrote: > //Ping// @tejohnson @ormris, I think that since @tejohnson originally suggested that someone with

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. //Ping// @tejohnson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69732/new/ https://reviews.llvm.org/D69732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. I've done testing with the following global parameters. - The base for the branch is llvmorg-10-init-8655-g94a4a2c97f8 - Used llvm, clang, lld, and llvm-ar from this branch. - The sqlite kvtest program was the test payload. This test compared an unmodified compiler from

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson marked an inline comment as done. tejohnson added a comment. In D69732#1733447 , @wristow wrote: > > This probably needs to be taken over by someone who cares about full LTO > > performance > > We at PlayStation are definitely interested in

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wristow added inline comments. Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:614 // during ThinLTO and perform the rest of the optimizations afterward. if (PrepareForThinLTO) { // Ensure we perform any last passes, but do so before renaming anonymous

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wristow added a comment. > This probably needs to be taken over by someone who cares about full LTO > performance We at PlayStation are definitely interested in full LTO performance, so we're looking into this. We certainly agree with the rationale that if suppressing some optimizations is

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wenlei added inline comments. Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:614 // during ThinLTO and perform the rest of the optimizations afterward. if (PrepareForThinLTO) { // Ensure we perform any last passes, but do so before renaming anonymous

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson added a comment. In D69732#1730884 , @wenlei wrote: > > The comments indicate that this is in part due to issues with > > the new PM loop pass manager > > Wondering how different it is for these loop passes to be enabled for MonoLTO > vs

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wenlei added a comment. > The comments indicate that this is in part due to issues with > the new PM loop pass manager Wondering how different it is for these loop passes to be enabled for MonoLTO vs ThinLTO? If it's due to problems with the newPM, I guess ThinLTO would have the same

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson added a comment. This probably needs to be taken over by someone who cares about full LTO performance (@wristow or @ormris ?). This patch was some cleanup of the full LTO sample PGO pipeline, but has a number of issues I enumerate in the summary. Repository: rG LLVM Github

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson created this revision. tejohnson added reviewers: wristow, ormris. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added projects: clang, LLVM. There are several modifications to the optimizations performed by the