ekatz marked an inline comment as done.
ekatz added inline comments.
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3133
return TokError("invalid floating point literal");
- } else if (Value.convertFromString(IDVal, APFloat::rmNearestTiesToEven) ==
-
smeenai added inline comments.
Herald added a subscriber: herhut.
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3133
return TokError("invalid floating point literal");
- } else if (Value.convertFromString(IDVal, APFloat::rmNearestTiesToEven) ==
-
craig.topper added inline comments.
Comment at: llvm/lib/Support/StringRef.cpp:593
+ if (!ErrOrStatus) {
+assert("Invalid floating point representation");
+return true;
This is an invalid assert.
lib/Support/StringRef.cpp:593:12: warning: implicit
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc5fb73c5d1b3: [APFloat] Add recoverable string parsing
errors to APFloat (authored by ekatz).
Changed prior to commit:
https://reviews.llvm.org/D69770?vs=227917=236304#toc
Repository:
rG LLVM Github
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
If we really want to be confident that this is robust, we should probably
fuzz-test it. Regardless, this seems like a definite improvement. LGTM.
CHANGES SINCE LAST ACTION
ekatz added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69770/new/
https://reviews.llvm.org/D69770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ekatz added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69770/new/
https://reviews.llvm.org/D69770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
