kimgr added a comment.
Oh, I see. I thought `rc.exe` was the one and only implementation. Fair enough,
this is probably the lesser of two evils :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70196/new/
https://reviews.llvm.org/D70196
rnk added a comment.
We already have llvm-rc.exe which one could plausibly use to compile rc files,
and I didn't like `binary.lower().endswith('rc.exe')` as a test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70196/new/
kimgr added a comment.
I wonder if it would be better to look at the compile-command than the source
file?
It's not unthinkable that someone would use another extension for an rc file,
or use a .rc extension for a C or C++ source file. But if the compiler is
rc.exe, the source file must be in
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe2369fd197d9: [clang-include-fixer] Skip .rc files when
finding symbols (authored by rnk).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70196/new/
rnk added a comment.
This is a single .rc entry:
{
"directory": "C:/src/llvm-project/build",
"command": "C:\\PROGRA~2\\WI3CF2~1\\10\\bin\\100183~1.0\\x64\\rc.exe
-DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_
DEPRECATE
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This seems fine as a workaround, but will obviously only affect include-fixer.
I'm wary of embedding it deeper without understanding the problem though.
Can you paste the *.rc entry
rnk created this revision.
rnk added reviewers: sammccall, bkramer.
Herald added a project: clang.
For some reason CMake includes entries for .rc files, but
find-all-symbols handles them improperly.
See PR43993
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70196
Files:
