[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-26 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx added a comment. In D70203#1760299 , @bjope wrote: > Hi @sammccall . > Just a heads up. Looks like this might have caused: > https://bugs.llvm.org/show_bug.cgi?id=44143 . Yes indeed. I locally reverted commit a433e714

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-26 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added a comment. Hi @sammccall . Just a heads up. Looks like this might have caused: https://bugs.llvm.org/show_bug.cgi?id=44143 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70203/new/ https://reviews.llvm.org/D70203

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa433e7141fb3: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D70203?vs=229157=229769#toc

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/Index/annotate-comments-typedef.m:20 } MyEnum; -// CHECK:

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/Index/annotate-comments-typedef.m:20 } MyEnum; -// CHECK: TypedefDecl=MyEnum:[[@LINE-1]]:3 (Definition) FullCommentAsHTML=[ Documentation for MyEnum ]

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang/test/Index/annotate-comments-typedef.m:20 } MyEnum; -// CHECK: TypedefDecl=MyEnum:[[@LINE-1]]:3 (Definition) FullCommentAsHTML=[ Documentation for MyEnum ] FullCommentAsXML=[anonymousc:@EA@MyEnumtypedef enum MyEnum MyEnum

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, lh123. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Semantically they're the same thing, and it's important when the underlying struct is anonymous. There