[PATCH] D70235: [clangd] Add isHeaderFile helper.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70235: [clangd] Add isHeaderFile helper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG509efe5d8ede: [clangd] Add isHeaderFile helper. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein updated this revision to Diff 229545. hokein marked an inline comment as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235 Files:

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:302 +bool isHeaderFile(llvm::StringRef FileName, + llvm::Optional LangOpts = None); + nit: = llvm::None Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:1133 + Lang != types::TY_INVALID && types::onlyPrecompileType(Lang); + if (!LangOpts) +return

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein added a comment. in case you miss this patch, I saw you have stamped the other patch depends on this patch, but this patch still needs approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235

[PATCH] D70235: [clangd] Add isHeaderFile helper.

merge_guards_bot added a comment. Build result: pass - 60058 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein updated this revision to Diff 229300. hokein added a comment. take langOpts into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall added a comment. As discussed offline, we still want to respect the langopts signal, but we also want to treat *.h as a header if it's not present. So the function needs to take filename and langopts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70235: [clangd] Add isHeaderFile helper.

merge_guards_bot added a comment. Build result: pass - 60058 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. we have a few places using `ASTCtx.getLangOpts().IsHeaderFile` to determine a header file, but it relies on