[PATCH] D70257: [BPF] Restrict preserve_access_index attribute to C only

2019-11-14 Thread Yonghong Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd16b3fe2559: [BPF] Restrict preserve_access_index attribute to C only (authored by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D70257?vs=229355=229406#toc Repository: rG LLVM

[PATCH] D70257: [BPF] Restrict preserve_access_index attribute to C only

2019-11-14 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3431 -const auto *RecT = dyn_cast(ElaborateT->desugar().getTypePtr()); -if (!RecT) - return false; - -return

[PATCH] D70257: [BPF] Restrict preserve_access_index attribute to C only

2019-11-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Thank you! Comment at: clang/lib/CodeGen/CGExpr.cpp:3431 -const auto *RecT = dyn_cast(ElaborateT->desugar().getTypePtr());

[PATCH] D70257: [BPF] Restrict preserve_access_index attribute to C only

2019-11-14 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. yonghong-song retitled this revision from "[BPF] Restrict preserve_access_index to C only" to "[BPF] Restrict preserve_access_index