[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

2019-11-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: hokein, lh123. Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. This is shorter, shouldn't be confusing (is consistent with how they're declared), and avoids messy cases that are p

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

2019-11-16 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGfa3b87fbeb46: [CodeComplete] Constructor overload candidates report as vector(int) instead of… (authored by sammccall). Repository: rG LLVM Github Monorepo C

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

2019-11-16 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60091 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

2019-11-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/CodeCompletion/templates.cpp:35 +// CHECK-CONSTRUCTOR: OVERLOAD: X(<#double#>) +// (rather than X(<#double#>) hokein wrote: > shouldn't be now `X` after your recen

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

2019-11-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeCompletion/templates.cpp:35 +// CHECK-CONSTRUCTOR: OVERLOAD: X(<#double#>) +// (rather than X(<#double#>) shouldn't be now `X`