[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-19 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec071409807: [clangd] More sensible output for constructors/destructors in hover. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D703

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60168 tests passed, 0 failed and 731 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:598 +// Constructor's "return type" is the class type. +HI.ReturnType = declaredType(CCD->getParent()).getAsString(Policy); +// Don't provide an

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 229900. sammccall marked 2 inline comments as done. sammccall added a comment. Update tests and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70317/new/ https://reviews.llvm.org/D70317 Files: clang-

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:598 +// Constructor's "return type" is the class type. +HI.ReturnType = declaredType(CCD->getParent()).getAsString(Policy); +// Don't provide any type for the constructor itself.

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-16 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60137 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously: both had type void() and return type void. Now: neither have a type. Constructors