[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

kousikk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese added a comment. I mostly just need to rebase this patch now. I'll try to get to that soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

kousikk added a comment. @Bigcheese wondering if there are things with respect to testing we can do, to help the patch move forward :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese added a comment. I was finally able to land the patch this depended on. Still waiting on review for this. In the meantime I've tested this ABI out by building a simple program that outputs a ninja file given a command line. It depends on a bunch of changes to the Clang side of

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese updated this revision to Diff 232484. Bigcheese marked an inline comment as done. Bigcheese added a comment. Herald added a subscriber: mgrang. - Remove duplicate decl - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese marked an inline comment as done. Bigcheese added inline comments. Comment at: clang/include/clang-c/Dependencies.h:146 + */ +typedef struct CXOpaqueDependencyScannerWorker *CXDependencyScannerWorker; + kousikk wrote: > It would be simpler if the

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

kousikk added inline comments. Comment at: clang/include/clang-c/Dependencies.h:146 + */ +typedef struct CXOpaqueDependencyScannerWorker *CXDependencyScannerWorker; + It would be simpler if the clients didn't have to worry about the worker? As far as a user of

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added inline comments. Comment at: clang/include/clang-c/Dependencies.h:205 + */ +CINDEX_LINKAGE void clang_experimental_DependencyScannerWorker_dispose_v0( +CXDependencyScannerWorker); Looks like you have a duplicate declaration of this function,

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added a comment. I think this patch is missing tests for the C api that use c-index-test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese added a comment. In D70351#1754276 , @arphaman wrote: > Adding experimental APIs is something that we haven't done before, but it be > useful for this case. Yep, I'm currently aware of two other people who care about this interface, so I

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added a comment. Adding experimental APIs is something that we haven't done before, but it be useful for this case. I have a couple of questions about the API: - Should types be prefixed / suffixed with experimental / v0 in case we need to extend the information passed to the client?

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese created this revision. Bigcheese added reviewers: arphaman, kousikk. Herald added subscribers: llvm-commits, cfe-commits, tschuett, dexonsmith, mgorny. Herald added projects: clang, LLVM. Bigcheese added a parent revision: D70268: [clang][clang-scan-deps] Aggregate the full dependency