[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: pass - 60178 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70359: [clangd] Show values of more expressions on hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d93c3d0b4a: [clangd] Show values of more expressions on hover (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/

[PATCH] D70359: [clangd] Show values of more expressions on hover

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://reviews.llvm.org/D70359

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall updated this revision to Diff 230058. sammccall added a comment. Fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://reviews.llvm.org/D70359 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D70359: [clangd] Show values of more expressions on hover

kadircet added a comment. it feels like rebasing went wrong :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://reviews.llvm.org/D70359 ___ cfe-commits mailing list

[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: fail - 60136 tests passed, 2 failed and 729 were skipped. failed: LLVM.CodeGen/NVPTX/vectorize-misaligned.ll failed: LLVM.Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll Log files: console-log.txt

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:255 + // Show enums symbolically, not numerically like APValue::printPretty(). + if (E->getType()->isEnumeralType() && + Constant.Val.getInt().getMinSignedBits() <= 64) {

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall added a comment. "mouseover" all_the_things "all the things" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/

[PATCH] D70359: [clangd] Show values of more expressions on hover

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:247 + // to the enclosing call. + if (E->getType()->isFunctionType() || E->getType()->isFunctionPointerType() || +

[PATCH] D70359: [clangd] Show values of more expressions on hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } sammccall wrote: > lh123 wrote: > > I think we should also support hover on literal. > sure - can you

[PATCH] D70359: [clangd] Show values of more expressions on hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } lh123 wrote: > sammccall wrote: > > lh123 wrote: > > > I think we should also support hover on

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } lh123 wrote: > I think we should also support hover

[PATCH] D70359: [clangd] Show values of more expressions on hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } I think we should also support hover on literal. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: fail - 60143 tests passed, 2 failed and 729 were skipped. failed: Clangd Unit Tests._/ClangdTests/FindExplicitReferencesTest.All failed: LLVM.Bindings/Go/go.test Log files: console-log.txt

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70359 Files: