[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

This revision was automatically updated to reflect the committed changes. sbc100 marked an inline comment as done. Closed by commit rG881d877846e2: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export… (authored by sbc100). Changed prior to commit:

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

dschuff added inline comments. Comment at: lld/test/wasm/export-name.ll:20 +; CHECK-NEXT:Exports: +; CHECK-NEXT: - Name:memory +; CHECK-NEXT:Kind:MEMORY sbc100 wrote: > dschuff wrote: > > does this test need to verify

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: lld/test/wasm/export-name.ll:20 +; CHECK-NEXT:Exports: +; CHECK-NEXT: - Name:memory +; CHECK-NEXT:Kind:MEMORY

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 added a comment. Ping .. I think this is good to go now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 ___ cfe-commits mailing list

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 updated this revision to Diff 232673. sbc100 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 Files: clang/include/clang/Basic/Attr.td

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 updated this revision to Diff 231620. sbc100 added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 Files: clang/include/clang/Basic/Attr.td

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 added a comment. In D70520#1754500 , @sunfish wrote: > It appears this doesn't handle exporting an imported function yet, which is > fine for now, but it would be good to issue a warning, because wasm itself is > capable of representing this: > >

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 updated this revision to Diff 231618. sbc100 marked an inline comment as done. sbc100 added a comment. - Add support for asm parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 Files:

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sunfish added a comment. > Do you think that setting this attribute should also prevent GC? That sounds right to me. > I could split this up into clang, llvm, and lld parts if it makes reviewing > simpler. For me, it's easier to have it all together in one. In this patch, `export_name` has a

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sunfish added a comment. It appears this doesn't handle exporting an imported function yet, which is fine for now, but it would be good to issue a warning, because wasm itself is capable of representing this: void aaa(void) __attribute__((import_module("imp"), import_name("foo"),

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. sbc100 added a comment. sbc100 added reviewers: dschuff, sunfish. First stab at getting this attribute plumbed all the

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 added a comment. First stab at getting this attribute plumbed all the way through. Do you think that setting this attribute should also prevent GC? I could split this up into clang, llvm, and lld parts if it makes reviewing simpler. Repository: rG LLVM Github Monorepo CHANGES SINCE