[PATCH] D70613: Add method to ignore invisible AST nodes

2019-12-18 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG98e8f774eb6c: Add method to ignore invisible AST nodes (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D70613?vs=233183=234623#toc Repository: rG LLVM Github Monorepo

[PATCH] D70613: Add method to ignore invisible AST nodes

2019-12-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70613/new/ https://reviews.llvm.org/D70613

[PATCH] D70613: Add method to ignore invisible AST nodes

2019-12-10 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 233183. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70613/new/ https://reviews.llvm.org/D70613 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D70613: Add method to ignore invisible AST nodes

2019-12-10 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked 10 inline comments as done. steveire added a comment. It wasn't possible to add the `const` because of the return type. Comment at: clang/include/clang/AST/Expr.h:769-770 + /// implicit conversions. + Expr *IgnoreInvisible(); + const Expr *IgnoreInvisible()

[PATCH] D70613: Add method to ignore invisible AST nodes

2019-12-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:769-770 + /// implicit conversions. + Expr *IgnoreInvisible(); + const Expr *IgnoreInvisible() const { +return const_cast(this)->IgnoreInvisible(); `Invisible` is a bit of an

[PATCH] D70613: Add method to ignore invisible AST nodes

2019-11-22 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70613 Files: clang/include/clang/AST/ASTNodeTraverser.h