[PATCH] D70615: Add an -fno-temp-file flag for compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde7b6bcda9d: Re-land Add an -fno-temp-file flag for compilation (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen updated this revision to Diff 234563. zahen added a comment. Fixed MemorySanitizer: use-of-uninitialized-value warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Driver/Options.td

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen reopened this revision. zahen added a comment. This revision is now accepted and ready to land. Sorry about that I'll add a corrected patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615

RE: [PATCH] D70615: Add an -fno-temp-file flag for compilation

-commits@lists.llvm.org; mlek...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com; peter.wal...@arm.com Subject: [PATCH] D70615: Add an -fno-temp-file flag for compilation hans added a comment. Sorry for the breakage, and thanks for reverting! I'll try to follow up and fix this tomorrow

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. Sorry for the breakage, and thanks for reverting! I'll try to follow up and fix this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hctim added a comment. This change broke the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/37446 Reverted in `b19d87b16f81e7c0a22a0a103c867c1b844eb8bc` TEST 'Clang-Unit :: Frontend/./FrontendTests/PCHPreambleTest.ParseWithBom'

[PATCH] D70615: Add an -fno-temp-file flag for compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rGd129aa1d5369 (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files:

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. In D70615#1789142 , @zahen wrote: > Any additional changes required? If not could someone please submit on my > behalf? @rnk, @hans, @thakis ? Sorry, this got lost in my email. I've committed it as

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. Any additional changes required? If not could someone please submit on my behalf? @rnk, @hans, @thakis ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 ___ cfe-commits

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. Thanks Hans! I'll need someone to do the actual submission since I don't have commit rights. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 ___ cfe-commits mailing list

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I see. For some reason I thought the temporary files would be written elsewhere, like in /tmp, but I see that's not the case, and I guess it also makes sense to avoid having to copy it between

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. In our build system every file access in an "output directory" needs to be accounted for. Until this patch, the random temporary file name has forced us to rely on workarounds that hurt build throughput. I've uploaded example ProcMon dumps of clang-cl.exe file accesses

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. > Our build system does not handle randomly named files created during the > build well. Can you share more details about why this is a problem? At least the build systems I work with would not even see the temporary files, as they're written to /tmp or similar, and

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. In D70615#1770550 , @hans wrote: > Seems fine to me. I'm not sure how to test the actual "don't write to temp > file" functionality, but at least there could be a test to check that the > flag gets forwarded to cc1. Added a best

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen updated this revision to Diff 232442. zahen added a comment. Fixed patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Driver/Options.td clang/include/clang/Frontend/FrontendOptions.h

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen updated this revision to Diff 232441. zahen added a comment. Updated with review feedback and formatting fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Driver/Options.td

[PATCH] D70615: Add an -fno-temp-file flag for compilation

thakis added a comment. In D70615#1769751 , @rnk wrote: > +more reviewers > > This doesn't add any code complexity, we already have the boolean UseTempFile > flag, so I think we should do this. I would also point out that right now, in > my LLVM build

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. Seems fine to me. I'm not sure how to test the actual "don't write to temp file" functionality, but at least there could be a test to check that the flag gets forwarded to cc1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70615: Add an -fno-temp-file flag for compilation

rnk added a comment. +more reviewers This doesn't add any code complexity, we already have the boolean UseTempFile flag, so I think we should do this. I would also point out that right now, in my LLVM build directory on Windows, I have 895 *.obj.tmp files: $ find . -iname '*.obj.tmp' | wc

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen created this revision. zahen added reviewers: rsmith, rnk, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our build system does not handle randomly named files created during the build well. We'd prefer to write compilation output directly without creating