This revision was automatically updated to reflect the committed changes.
Closed by commit rG5ee616a710bc: [analyzer] Fix SARIF column locations
(authored by jranieri-grammatech).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70689/new/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! I think we've had sufficient time for other reviewers to lodge concerns
and we can deal with any other issues post-commit. Do you need me to commit on
your behalf?
jranieri-grammatech updated this revision to Diff 235219.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70689/new/
https://reviews.llvm.org/D70689
Files:
clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
jranieri-grammatech marked an inline comment as not done.
jranieri-grammatech added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:157
+ const MemoryBuffer *Buf = SM.getBuffer(LocInfo.first);
+ assert(Buf && "got a NULL buffer for the
aaron.ballman added reviewers: dblaikie, echristo, xbolva00.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Mostly LG aside from a question about an assertion. Adding other reviewers
outside of GrammaTech in case there are other concerns we've missed.
jranieri-grammatech updated this revision to Diff 234971.
jranieri-grammatech added a comment.
Addressed review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70689/new/
https://reviews.llvm.org/D70689
Files:
jranieri-grammatech marked 4 inline comments as done.
jranieri-grammatech added inline comments.
Comment at: clang/test/Analysis/diagnostics/sarif-multi-diagnostic-test.c:35-36
+{
+ int løçål = 0;
+ /* ☃ */ return 1 / løçål; // expected-warning {{Division by zero}}
+}
aaron.ballman added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:31
std::string OutputFile;
+ const Preprocessor
You don't really need the whole preprocessor, just the language options, right?
If so, why not thread the
jranieri-grammatech created this revision.
jranieri-grammatech added a reviewer: aaron.ballman.
Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a project: clang.
This fixes SARIF
