This revision was automatically updated to reflect the committed changes.
Closed by commit rG1a4ee4c88f21: [clangd] Find reference to template parameter
in sizeof... expression (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM! Many thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70740/new/
https://reviews.llvm.org/D70740
nridge updated this revision to Diff 232011.
nridge added a comment.
Add FindExplicitReferences test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70740/new/
https://reviews.llvm.org/D70740
Files:
clang-tools-extra/clangd/FindTarget.cpp
ilya-biryukov added a comment.
Could you add another test for `findExplicitReferences` too? Those tests are
right after `targetDecl`.
These two functions kinda duplicate each other a lot, but that's intentional -
those two functions do a somewhat similar thing and we want to keep them in
sync
nridge updated this revision to Diff 231608.
nridge added a comment.
Address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70740/new/
https://reviews.llvm.org/D70740
Files:
clang-tools-extra/clangd/FindTarget.cpp
ilya-biryukov added a comment.
Thanks! Could you also handle this in `targetDecl` and add the corresponding
test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70740/new/
https://reviews.llvm.org/D70740
nridge added a comment.
Fixes https://github.com/clangd/clangd/issues/213
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70740/new/
https://reviews.llvm.org/D70740
___
cfe-commits mailing list
nridge created this revision.
nridge added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70740
Files: