[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rGde3dbc4f4166: [clangd] Highlighting dependent types in more contexts (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70746/new/

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

nridge updated this revision to Diff 232012. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70746/new/ https://reviews.llvm.org/D70746 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks! LGTM Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:275 + if (NNS->getKind() == NestedNameSpecifier::Identifier) { +

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

nridge updated this revision to Diff 231609. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70746/new/ https://reviews.llvm.org/D70746 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:259 H.addToken(L.getNameLoc(), HighlightingKind::DependentType); +visitDependentTypesInQualifier(L.getQualifierLoc()); +return true; Instead of

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

nridge created this revision. nridge added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70746 Files: