[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall added a comment. In D70872#1785797 , @gribozavr2 wrote: > which is intentionally not supported in clangd tests Not intentionally as far as I'm aware :-) Do you have a link or details for some failing environment? I'm OOO but I'd like to

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

gribozavr2 added a comment. Sorry, I reverted this change in 079ef783dd5530b5f87beefe624b9179547ded7e . The tests depend on builtin headers, which is not intentionally supported in clangd tests; these tests are broken in some

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6417f5584aa: [clangd] Implement textDocument/documentLink protocol support (authored by MForster, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster added a comment. In D70872#1781703 , @sammccall wrote: > Thanks! I'll land this for you. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I'll land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster updated this revision to Diff 233433. MForster marked an inline comment as not done. MForster added a comment. Adress review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872 Files:

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster marked 6 inline comments as done. MForster added a comment. I think I addressed all review comments. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall added a comment. Ping - how do you want to proceed here? I think the only thing that is really missing here is a unit test, I can add it if you don't have cycles. I'll be gone after this week :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall added a comment. Thanks, looks nice! It occurred to me we could compute (but not resolve) the ranges cheaply to speed up the UI. We don't need to do this now. Only real thing to do is add a gunit test. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1204

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang-tools-extra/clangd/test/document-link.test:21 +# CHECK-NEXT: }, +# CHECK-NEXT: "target": "file://{{.*}}/iostream" +# CHECK-NEXT:}, Originally I tried to