[PATCH] D71033: [analyzer] CERT: STR32-C

2020-01-31 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 241761. Charusso added a comment. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/ https://reviews.llvm.org/D71033 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D71033: [analyzer] CERT: STR32-C

2019-12-13 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. We need to add the interestingness to the `NoteTags` so that we only emit notes on initialization/function calls which leads to an error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/ https://reviews.llvm.org/D71033

[PATCH] D71033: [analyzer] CERT: STR32-C

2019-12-13 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:479 +if (VD->getType()->getAsArrayTypeUnsafe()) { + VD->dumpColor(); + ProgramStateRef State = C.getState();

[PATCH] D71033: [analyzer] CERT: STR32-C

2019-12-13 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 233904. Charusso retitled this revision from "[analyzer] CERT: StrChecker: 32.c" to "[analyzer] CERT: STR32-C". Charusso added a comment. - Add notes to the initialization of char-arrays. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/