[PATCH] D71272: [OpenCL] Pretty print __private addr space

2019-12-13 Thread Alexey Sotkin via Phabricator via cfe-commits
AlexeySotkin added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of incompatible type '__read_only image1d_t'}} +

[PATCH] D71272: [OpenCL] Pretty print __private addr space

2019-12-13 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of

[PATCH] D71272: [OpenCL] Pretty print __private addr space

2019-12-13 Thread Alexey Sotkin via Phabricator via cfe-commits
AlexeySotkin added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of incompatible type '__read_only image1d_t'}} +

[PATCH] D71272: [OpenCL] Pretty print __private addr space

2019-12-12 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71272/new/ https://reviews.llvm.org/D71272 ___ cfe-commits mailing list

[PATCH] D71272: [OpenCL] Pretty print __private addr space

2019-12-11 Thread Alexey Bader via Phabricator via cfe-commits
bader added a subscriber: AlexeySotkin. bader added a comment. LGTM, but I'd like someone who works on OpenCL front-end to approve. +@AlexeySotkin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71272/new/ https://reviews.llvm.org/D71272 ___