[PATCH] D71422: [clangd] Introduce bulletlists

2020-01-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGa000f2e53f5c: [clangd] Introduce bulletlists (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D71422?vs=234059=236574#toc

[PATCH] D71422: [clangd] Introduce bulletlists

2020-01-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FormattedString.cpp:156 +// indented. +std::string indentLines(llvm::StringRef Input) { + std::string IndentedR;

[PATCH] D71422: [clangd] Introduce bulletlists

2019-12-16 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60933 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71422: [clangd] Introduce bulletlists

2019-12-16 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 234059. kadircet marked 2 inline comments as done. kadircet added a comment. - Move indentation logic into bulletlist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71422/new/ https://reviews.llvm.org/D71422

[PATCH] D71422: [clangd] Introduce bulletlists

2019-12-16 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.h:95 + /// Causes every line of the document to be indented by 2 spaces. Except the + /// first line, it is containers responsibility to adjust padding for first sammccall

[PATCH] D71422: [clangd] Introduce bulletlists

2019-12-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.h:65 +/// Prints a list of documents while prepending "- " marker. Also indents the +/// documents. This is a class, not a function - comment should focus on what it *is*.

[PATCH] D71422: [clangd] Introduce bulletlists

2019-12-12 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , diff.json

[PATCH] D71422: [clangd] Introduce bulletlists

2019-12-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71422 Files: