[PATCH] D71439: Allow redeclaration of __declspec(uuid)

2019-12-28 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0acfc493171a: Allow redeclaration of __declspec(uuid) (authored by zahen, committed by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71439/new/

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

2019-12-28 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D71439#1789141 , @zahen wrote: > @rnk Can you please submit on my behalf. I don't have commit access. Sorry for the delay, I pushed it today. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

2019-12-17 Thread Zachary Henkel via Phabricator via cfe-commits
zahen added a comment. @rnk Can you please submit on my behalf. I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71439/new/ https://reviews.llvm.org/D71439 ___ cfe-commits

Re: [PATCH] D71439: Allow redeclaration of __declspec(uuid)

2019-12-13 Thread Zachary Henkel via cfe-commits
...@chromium.org ; ztur...@roblox.com Cc: cfe-commits@lists.llvm.org ; mlek...@skidmore.edu ; blitzrak...@gmail.com ; shen...@google.com Subject: [PATCH] D71439: Allow redeclaration of __declspec(uuid) rnk accepted this revision. rnk added a comment. This revision is now accepted and ready

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

2019-12-12 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71439/new/ https://reviews.llvm.org/D71439

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

2019-12-12 Thread Zachary Henkel via Phabricator via cfe-commits
zahen created this revision. zahen added reviewers: rnk, thakis, hans, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. msvc allows a subsequent declaration of a uuid attribute on a struct/class. Mirror this behavior in clang-cl. Repository: rG LLVM Github