[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1820589 , @rjmccall wrote: > I think I have a slight preference for the second option, where there's a > single method that does all the work for the two cases. OK, now checked in as 870137d

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

rjmccall added a comment. > Well, just like for all the other FP builder methods, you can use the > setIsFPConstrained method on the builder object to switch between strict and > non-strict mode. Does this not suffice, or is there anything particular about > the comparisons that would require

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1817939 , @rjmccall wrote: > Is this approach going to work with scope-local strictness? We need a way to > do a comparison that has the non-strict properties but appears in a function > that enables strictness

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

rjmccall added a comment. Is this approach going to work with scope-local strictness? We need a way to do a comparison that has the non-strict properties but appears in a function that enables strictness elsewhere. Comment at: llvm/include/llvm/IR/IRBuilder.h:2342

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG76e9c2a9870e: [FPEnv] Generate constrained FP comparisons from clang (authored by uweigand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/ https://reviews.llvm.org/D71467 ___ cfe-commits mailing list

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. Ping again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/ https://reviews.llvm.org/D71467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/ https://reviews.llvm.org/D71467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1786192 , @erichkeane wrote: > __builtin_fpclassify/isfinite/isinf/isinf_sign/isnan/isnormal/signbit are all > implemented the same as the OTHER ones, except there is a strange fixup step > in SEMA that removes the

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

erichkeane added a comment. In D71467#1786188 , @uweigand wrote: > In D71467#1785943 , @erichkeane > wrote: > > > I did the compare operators that didn't work right, and will do a separate > > patch for the

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1785943 , @erichkeane wrote: > I did the compare operators that didn't work right, and will do a separate > patch for the fp-classification type ones: > f02d6dd6c7afc08f871a623c0411f2d77ed6acf8 >

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand updated this revision to Diff 234096. uweigand added a comment. Added float (f32) test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/ https://reviews.llvm.org/D71467 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen/fpconstrained-cmp-double.c

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

erichkeane added a comment. In D71467#1784398 , @erichkeane wrote: > In D71467#1784338 , @craig.topper > wrote: > > > In D71467#1784286 , @rjmccall > > wrote: > > > > >

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

erichkeane added a comment. In D71467#1784338 , @craig.topper wrote: > In D71467#1784286 , @rjmccall wrote: > > > The bug with `__builtin_isless` should be a really easy fix; the builtin > > just needs to be

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

craig.topper added a subscriber: erichkeane. craig.topper added a comment. In D71467#1784286 , @rjmccall wrote: > The bug with `__builtin_isless` should be a really easy fix; the builtin just > needs to be flagged as having custom type-checking, and then

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

rjmccall added a comment. The bug with `__builtin_isless` should be a really easy fix; the builtin just needs to be flagged as having custom type-checking, and then we need to make sure we do appropriate promotions on the arguments (but we probably do). Repository: rG LLVM Github Monorepo

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand created this revision. uweigand added reviewers: kpn, andrew.w.kaylor, craig.topper, cameron.mcinally, RKSimon, spatel, rjmccall, rsmith. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Update the IRBuilder to generate constrained FP comparisons