[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

2019-12-16 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3a93756dfbb0: [WebAssembly] Replace SIMD int min/max builtins with patterns (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71500/new/

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

2019-12-16 Thread Thomas Lively via Phabricator via cfe-commits
tlively marked an inline comment as done. tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189 + setOperationAction(Op, T, Legal); +} + aheejin wrote: > Just curious, what gets assigned we don't do

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

2019-12-16 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189 + setOperationAction(Op, T, Legal); +} + Just curious, what gets

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

2019-12-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60871 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

2019-12-13 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. The instructions were originally implemented via builtins and intrinsics so users