aeubanks added a comment.
I'm looking at enabling the -enable-npm-optnone flag and FullUnroll.ll fails. I
understand that loop unrolling should be forced when some metadata is present,
but the FullUnroll.ll test seems to check for a lot more than that. It checks
for (roughly) two unconditional
echristo closed this revision.
echristo added a comment.
Committed a while back.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
___
cfe-commits mailing list
chandlerc accepted this revision.
chandlerc added a comment.
Cool, thanks and LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
___
cfe-commits mailing
echristo updated this revision to Diff 267424.
echristo marked an inline comment as done.
echristo added a comment.
Update and restructure some test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
echristo marked 7 inline comments as done.
echristo added a comment.
Done. New diff incoming.
Comment at: clang/test/Misc/loop-opt-setup.c:12
+// Check br i1 to make sure that the loop is fully unrolled
// CHECK-NOT: br i1
chandlerc wrote:
> This is dead
chandlerc added inline comments.
Comment at: clang/test/Misc/loop-opt-setup.c:12
+// Check br i1 to make sure that the loop is fully unrolled
// CHECK-NOT: br i1
This is dead now that you have different prefixes...
Comment at:
echristo marked 6 inline comments as done.
echristo added a comment.
OK, ready again :)
Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6
+; We don't end up deleting the loop, but we remove everything inside of it so
checking for any
+; reasonable instruction from
echristo updated this revision to Diff 262458.
echristo added a comment.
Update and reduce testcase a bit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
Files:
clang/test/Misc/loop-opt-setup.c
chandlerc added a comment.
Wooot about finally having a test case! (Sorry for nit picking it a bit )
Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6
+; We don't end up deleting the loop, but we remove everything inside of it so
checking for any
+; reasonable
echristo updated this revision to Diff 261928.
echristo edited the summary of this revision.
echristo added a comment.
Herald added a subscriber: zzheng.
Add a testcase with opt and command line option so we can enable it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
vitalybuka accepted this revision.
vitalybuka added a comment.
Can this be landed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
___
cfe-commits mailing list
echristo updated this revision to Diff 250232.
echristo added a comment.
Fix comments around full unroller.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
Files:
clang/test/Misc/loop-opt-setup.c
echristo updated this revision to Diff 250229.
echristo added a comment.
Fixed the clang test.
Tried to get something that I could reduce down and duplicate with just opt but
it's been... difficult. Even the small clang testcase in isolation won't
duplicate via something like:
clang -O0
chandlerc added a comment.
Can we add an LLVM test w/ the metadata so that we have an entirely LLVM test
flow that ensures the pass builder DTRT?
(I still would include the Clang side test which is also very useful to test
integrating Clang w/ different flows through the pass manager.)
mehdi_amini added inline comments.
Comment at: llvm/lib/Passes/PassBuilder.cpp:484
+LPM2.addPass(LoopFullUnrollPass(Level,
+/*OnlyWhenForced=*/!PTO.LoopUnrolling,
PTO.ForgetAllSCEVInLoopUnroll));
MaskRay added inline comments.
Comment at: clang/test/Misc/loop-opt-setup.c:13
+int B(void) {
+#pragma clang loop unroll(full)
+ for (int i = 0; i < 16; ++i)
The test seems to pass without the code change
(llvm/lib/Passes/PassBuilder.cpp) below.
Repository:
echristo added a comment.
Ping ping goes the trolley.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61011 tests passed, 0 failed
and 728 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61011 tests passed, 0 failed
and 728 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
echristo created this revision.
echristo added reviewers: chandlerc, hfinkel, asbirlea.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier.
Herald added projects: clang, LLVM.
echristo updated this revision to Diff 234656.
echristo added a comment.
Formatting and parens
echristo updated this revision to Diff 234656.
echristo added a comment.
Formatting and parens changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71687/new/
https://reviews.llvm.org/D71687
Files:
clang/test/Misc/loop-opt-setup.c
21 matches
Mail list logo
