[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil abandoned this revision. jankratochvil added a comment. Thanks for the reminder, I have todolisted it now for myself but for now I am abandoning it as I cannot promise anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

aaron.ballman added a comment. In D71707#1821903 , @jankratochvil wrote: > In D71707#1796671 , @aaron.ballman > wrote: > > > Have you considered language extensions like `__ptr32`, `__ptr64`, > > `__sptr`, and

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil marked 8 inline comments as done. jankratochvil added a comment. In D71707#1796671 , @aaron.ballman wrote: > I agree that restricting casts to `intptr_t` is too restrictive. Permitted `intptr_t`. But then implemented also checking a cast

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 238260. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

aaron.ballman added a comment. Herald added a subscriber: whisperity. In D71707#1791394 , @jankratochvil wrote: > In D71707#1791280 , @labath wrote: > > > - disallowing casts to intptr_t seems too restrictive -- I

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Check for cast of a pointer to wider (even unsigned) integer. This will + sign-extend the pointer which happens on 32-bit hosts for

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 234787. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Check for cast of a pointer to wider (even unsigned) integer. This will + sign-extend the pointer which happens on 32-bit hosts for 64-bit integers. Checks. One

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 234772. jankratochvil added a comment. Wrote the documentation and Release Notes entry, thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil added a subscriber: labath. jankratochvil added a comment. In D71707#1791280 , @labath wrote: > - disallowing casts to intptr_t seems too restrictive -- I doubt many people > are doing that, but I guess this type exists for a reason, and

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

Eugene.Zelenko added a comment. Please add documentation and mention new check in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 ___

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

labath resigned from this revision. labath added a comment. Though this *was* my idea, I don't really feel qualified to review code here. However, some things to consider: - disallowing casts to intptr_t seems too restrictive -- I doubt many people are doing that, but I guess this type exists

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil added a comment. Example output: PATH="$PWD/bin:$PATH" ~/redhat/llvm-monorepo/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,bugprone-pointer-cast-widening' /home/jkratoch/redhat/llvm-monorepo/lldb/source/ Enabled checks:

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil created this revision. jankratochvil added reviewers: labath, alexfh, lebedev.ri. jankratochvil added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Check for cast of a pointer to wider (even unsigned)