[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

2019-12-19 Thread Warren Ristow via Phabricator via cfe-commits
wristow added a comment. Thanks for the quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71718/new/ https://reviews.llvm.org/D71718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

2019-12-19 Thread Warren Ristow via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7fcd9e3f7083: [X86] Mark various pointer arguments in builtins as const (authored by wristow). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

2019-12-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71718/new/ https://reviews.llvm.org/D71718 ___ cfe-commits mailing list

[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

2019-12-19 Thread Warren Ristow via Phabricator via cfe-commits
wristow created this revision. wristow added a reviewer: craig.topper. Enabling `-Wcast-qual` identified many casts in various system headers that were dropping the `const` qualifier. Fixing those missing qualifiers pointed out that a few of the definitions of the builtins did not properly