[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn closed this revision. kpn added a comment. My pleasure! Closed with commit 89d6c288ba5adb20d92142e9425f7ab79b8f159e . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 ___ cfe-commits mailing list

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn updated this revision to Diff 235880. kpn added a comment. Update now-failing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-systemz-vector.c

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

uweigand added a comment. Otherwise this LGTM. Thanks for taking care of those! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 ___ cfe-commits mailing list

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

uweigand requested changes to this revision. uweigand added a comment. This revision now requires changes to proceed. This also needs updating the test cases that are testing for the old behavior: Failing Tests (4): Clang :: CodeGen/builtins-systemz-vector.c Clang ::

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn created this revision. kpn added reviewers: cfe-commits, uweigand. Herald added a project: clang. The s390x builtins are still using FSub instead of FNeg. Correct that. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71854 Files: clang/lib/CodeGen/CGBuiltin.cpp Index: