[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-02 Thread Jim Lin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8188c998ffa4: [docs] Update path to clang-tools-extra (authored by AlexanderLanin, committed by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-02 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin added a comment. @Jim `git commit --amend --author="Alexander Lanin "` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new/ https://reviews.llvm.org/D71982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Jim Lin via Phabricator via cfe-commits
Jim added a comment. @AlexanderLanin git commit --amend --author="What-is-your-name " ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new/ https://reviews.llvm.org/D71982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin updated this revision to Diff 235801. AlexanderLanin marked an inline comment as done. AlexanderLanin edited the summary of this revision. AlexanderLanin added a comment. Removed change in hacking page as discussed. Can someone commit this as apparently I cannot do it myself (I'll c

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. As you mention, we're already inconsistent with how we designate where the repo lives on disk, so I'm fine with landing this as-is and making the root part of the path consistent

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin marked 3 inline comments as done. AlexanderLanin added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:66 -Once you are done, change to the ``llvm/tools/clang/tools/extra`` directory, and +Once you are done, change to the ``llvm/c

[PATCH] D71982: [docs] Update path to clang-tools-extra

2019-12-31 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:66 -Once you are done, change to the ``llvm/tools/clang/tools/extra`` directory, and +Once you are done, change to the ``llvm/clang-tools-extra`` directory, and let's start! --

[PATCH] D71982: [docs] Update path to clang-tools-extra

2019-12-30 Thread Jim Lin via Phabricator via cfe-commits
Jim added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:66 -Once you are done, change to the ``llvm/tools/clang/tools/extra`` directory, and +Once you are done, change to the ``llvm/clang-tools-extra`` directory, and let's start!

[PATCH] D71982: [docs] Update path to clang-tools-extra

2019-12-30 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin updated this revision to Diff 235577. AlexanderLanin added a comment. Hi, I don't see the error message you mentioned anywhere, but I'm gonna assume it involves the number of surrounding lines. Here is another attempt with > git show HEAD -U99 > mypatch.patch --- Source of

[PATCH] D71982: [docs] Update path to clang-tools-extra

2019-12-30 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. +1, please upload a diff with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new/ https://reviews.llvm.org/D71982

[PATCH] D71982: [docs] Update path to clang-tools-extra

2019-12-29 Thread Jim Lin via Phabricator via cfe-commits
Jim added a comment. There shows "Context not available". Could you update for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new/ https://reviews.llvm.org/D71982 ___ cfe-commits mailing lis

[PATCH] D71982: [docs] Update path to clang-tools-extra

2019-12-29 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin created this revision. AlexanderLanin added projects: clang-tools-extra, clang. Herald added a subscriber: cfe-commits. > tools/clang/tools/extra has become > clang-tools-extra which was not updated in all docs. Also hacking page has an outdated anchor for git. Repository: r