[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG05eedf1f5b44: [clang][VerifyDiagnosticConsumer] Support filename wildcards (authored by arames, committed by jkorous). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames updated this revision to Diff 264048. arames edited the summary of this revision. arames added a comment. Rebase on top of tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 Files:

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames updated this revision to Diff 250247. arames added a comment. Apply `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames updated this revision to Diff 247087. arames added a comment. Rename and clarify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames marked 2 inline comments as done. arames added a comment. In D72100#1855483 , @jkorous wrote: > We should either simplify the implementation to reflect that we don't support > e. g. `*:42` (seems preferable to me) or have the codepaths that are >

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

jkorous added a comment. We should either simplify the implementation to reflect that we don't support e. g. `*:42` (seems preferable to me) or have the codepaths that are currently not accessible through `-fverify` tested by other means. Comment at:

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames updated this revision to Diff 239972. arames added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 Files:

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames marked 3 inline comments as done. arames added inline comments. Comment at: clang/test/Frontend/verify-any-file.c:4 +#include "verify-any-file.h" +// expected-error@*:1 {{unknown type name 'unexpected'}} +#include "verify-any-file.h" While testing, I

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

jkorous added inline comments. Comment at: clang/test/Frontend/verify-any-file.c:1 +// RUN: %clang_cc1 -verify %s 2>&1 + I feel that we should test the output with FileCheck to make it more robust. Seems like other tests for `-verify` do that. For example here:

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames added a comment. This is for example useful to add a catch-all clause like `// expected-note-re@*:* 1+ {{candidate function {{.+` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames added a reviewer: rsmith. This allows specifying `*` for the filename to match any file. For example: // expected-note@*:* {{Match this note in any file at any line.}} //