[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

2020-11-03 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:715 + +let Predicates = [BPFHasAtomicExt, BPFHasALU32], DecoderNamespace = "BPFALU32" in { + def XFADDW32 : XFALU32; i think -mcpu=v4 should include alu32. Otherwise the test matrix

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

2020-11-03 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrFormats.td:98 + +def BPF_ATOMIC_FETCH : BPFAtomicFlag<0x1>; jackmanb wrote: > Per Alexei's email comments let's call this BPF_FETCH? I can do this. Note naming in llvm may not be

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

2020-11-03 Thread Brendan Jackman via Phabricator via cfe-commits
jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrFormats.td:98 + +def BPF_ATOMIC_FETCH : BPFAtomicFlag<0x1>; Per Alexei's email comments let's call this BPF_FETCH? Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:765 +

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

2020-11-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 302478. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. changed encoding based on internal discussion on encoding add a test Repository: rG LLVM