[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman added a comment. In D72218#2381149 , @ffrankies wrote: > Moved test files `KERNEL.cl`, `VHDL.cl` and `vERILOG.cl` to the `uppercase` > subdirectory to prevent filename clashes in some environments. > > This is in response to the buildbot

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 303680. ffrankies added a comment. Moved test files `KERNEL.cl`, `VHDL.cl` and `vERILOG.cl` to the `uppercase` subdirectory to prevent filename clashes in some environments. This is in response to the buildbot failure where `Verilog.cl`, `KERNEL.cl`, and

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman closed this revision. aaron.ballman added a comment. In D72218#2364297 , @ffrankies wrote: > @aaron.ballman Can you please commit this on my behalf? My github username is > ffrankies . I've commit on your

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies marked 3 inline comments as done. ffrankies added a comment. @aaron.ballman Can you please commit this on my behalf? My github username is ffrankies . And could you take a look at D72241 altera single work item barrier check

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 301865. ffrankies marked an inline comment as done. ffrankies added a comment. Implemented changes requested by @aaron.ballman - Added a helper function that implements the string comparison logic - Clarified that check is case insensitive - Removed unused

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D72218#2334787 , @ffrankies wrote: > Addressed comments by @aaron.ballman regarding the diagnostic warning. > > I tried to add a test

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 298601. ffrankies marked 7 inline comments as done. ffrankies added a comment. Addressed comments by @aaron.ballman regarding the diagnostic warning. I tried to add a test case for when the filename is `kernel.cl`, `verilog.cl`, or `vhdl.cl`, but that did

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/KernelNameRestrictionCheck.cpp:90 +Check.diag(SM.getLocForStartOfFile(SM.getMainFileID()), + "Naming your OpenCL kernel source file 'kernel.cl', 'Verilog.cl'" +

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 295697. ffrankies removed a project: LLVM. ffrankies added a comment. Herald added a project: LLVM. Addressed changes requested by @Eugene.Zelenko and @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72218/new/

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/KernelNameRestrictionCheck.cpp:53 +void KernelNameRestrictionCheck::registerPPCallbacks( +const SourceManager , Preprocessor *PP, Preprocessor *ModuleExpanderPP) { + PP->addPPCallbacks(

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-kernel-name-restriction.rst:4 +altera-kernel-name-restriction + + Please make same length as text above. CHANGES SINCE LAST ACTION

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 294215. ffrankies edited the summary of this revision. ffrankies added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Rebased code and fixed merge conflicts with D66564 - Added

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 254301. ffrankies added a comment. - Updated underlying repo to https://github.com/llvm/llvm-project - Removed braces from one-line if-statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72218/new/ https://reviews.llvm.org/D72218 Files:

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 243945. ffrankies marked 9 inline comments as done. ffrankies edited the summary of this revision. ffrankies added a comment. Implemented changes requested by @Eugene.Zelenko: - Added empty lines around namespace block - Fixed use of auto keyword - Fixed

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/altera/KernelNameRestrictionCheck.cpp:13 +#include "clang/Lex/Preprocessor.h" + +using namespace clang::ast_matchers; Please include string, vector Comment at:

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/altera/KernelNameRestrictionCheck.cpp:21 +namespace { +class KernelNameRestrictionPPCallbacks : public PPCallbacks { +public: Please separate with empty line. Comment at:

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies created this revision. ffrankies added reviewers: alexfh, hokein, aaron.ballman. ffrankies added projects: clang-tools-extra, clang, LLVM. Herald added subscribers: mgehre, ormris, arphaman, xazax.hun, Anastasia, mgorny. This lint check is part of the FLOCL (FPGA Linters for OpenCL)