[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies added a comment. Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit on your behalf in 5a87f81fe9aee996dfe3a84dd833f0a48e093e7f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies marked 7 inline comments as done. ffrankies added a comment. @aaron.ballman If there are no more changes, can you please commit this on my behalf? My github username is ffrankies . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 332303. ffrankies added a comment. Implemented changes requested by @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Mostly just nits for the check, otherwise this LGTM. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:65 +} +if (isa(Loop) ||

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 329207. ffrankies added a comment. - Ran `git-clang-format HEAD^` - Addressed comments automatically added by the Lint: Pre-merge Checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files:

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 329082. ffrankies marked 6 inline comments as done. ffrankies added a comment. Rebased with the latest main branch to fix patch application errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files:

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 328935. ffrankies marked 4 inline comments as done. ffrankies added a comment. - Removed unnecessary braces. - Simplified boolean return statements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files:

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 328933. ffrankies added a comment. - Surrounded language constructs with double back ticks in `clang-tools-extra/docs/clang-tidy/checks/altera-unroll-loops.rst`. - Removed trailing whitespace. - Added single quotes around `#pragma unroll`s in diagnostics.

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-unroll-loops.rst:15 + +- This check is unable to determine the number of iterations in a `while` or + `do..while` loop; hence if such a loop is fully unrolled, a note is emitted

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 328579. ffrankies marked 12 inline comments as done. ffrankies added a comment. - Added support for `CXXForRangeStmt` loops - Added support for different for loop increments (`++`, `--`, `+=`, `-=`, `*=`, `\=`) - Depending on the exit condition, the

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:40 + "kernel performance could be improved by unrolling this loop with a " + "#pragma unroll directive"); + break;

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 313174. ffrankies added a comment. - Addressed comments from @njames93 - Rebased with latest master branch to make sure there are no merge issues with the latest committed altera check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/

[PATCH] D72235: [clang-tidy] new altera unroll loops check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:22 +void UnrollLoopsCheck::registerMatchers(MatchFinder *Finder) { + const auto ANYLOOP = anyOf(forStmt(), whileStmt(), doStmt()); + Finder->addMatcher(stmt(allOf(ANYLOOP, //

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 312676. ffrankies added a comment. - removed unnecessary comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 312675. ffrankies marked 9 inline comments as done. ffrankies added a comment. - Rebased with master branch - Diagnostics are re-worded so they're not complete sentences Check ready for further review CHANGES SINCE LAST ACTION

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 254299. ffrankies added a comment. Addressed comments by @Eugene.Zelenko - Removed braces from one-lien if statements - Release notes on the altera unroll loops check now match the first line of documentation. CHANGES SINCE LAST ACTION

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:41 + } + if (Unroll == PartiallyUnrolled) { +return; Please elide braces. Comment at:

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 248322. ffrankies added a comment. @Eugene.Zelenko It turns out we were using an old mirror of the clang-tools-extra repository, that no longer seems to be updated. I switched to the llvm-project

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added a comment. Please rebase from master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 246993. ffrankies marked 9 inline comments as done. ffrankies added a comment. Addressed comments by @Eugene.Zelenko - Used const auto * when type is mentioned in same sentence - Fixed formatting in documentation - Documented default value of

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added a comment. I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency. Comment at: clang-tidy/altera/UnrollLoopsCheck.cpp:31 +void UnrollLoopsCheck::check(const MatchFinder::MatchResult ) { +

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 236270. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyForceLinker.h clang-tidy/altera/AlteraTidyModule.cpp clang-tidy/altera/CMakeLists.txt

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies created this revision. ffrankies added reviewers: aaron.ballman, hokein, alexfh. ffrankies added projects: clang-tools-extra, clang, LLVM. Herald added subscribers: mgehre, arphaman, zzheng, xazax.hun, Anastasia, mgorny. ffrankies updated this revision to Diff 236270. ffrankies updated

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 236271. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyForceLinker.h clang-tidy/altera/AlteraTidyModule.cpp clang-tidy/altera/CMakeLists.txt