[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

gribozavr2 closed this revision. gribozavr2 added a comment. Superseded by https://reviews.llvm.org/D76355. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72446/new/ https://reviews.llvm.org/D72446 ___

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

hlopko added a comment. Taking over the patch in https://reviews.llvm.org/D76355. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:147 + void add(ASTPtr From, syntax::Tree *To) { +assert(To != nullptr); + gribozavr2 wrote: > Also assert that From is not

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:147 + void add(ASTPtr From, syntax::Tree *To) { +assert(To != nullptr); + Also assert tha

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

ilya-biryukov updated this revision to Diff 237042. ilya-biryukov added a comment. - Remove debug logs - Cosmetics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72446/new/ https://reviews.llvm.org/D72446 Files: clang/include/clang/Tooling/Syntax

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

ilya-biryukov updated this revision to Diff 237039. ilya-biryukov added a comment. Remove the (now redundant) NodeAndRole class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72446/new/ https://reviews.llvm.org/D72446 Files: clang/include/clang/T

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. ilya-biryukov updated this revision to Diff 237039. ilya-biryukov added a comment. ilya-biryukov added a parent revision: D72334: [Syntax] Build nodes for template declarations.. Remove