This revision was automatically updated to reflect the committed changes.
Closed by commit rGf5465e74ef4c: [clangd] Include expression in DecltypeTypeLoc
sourcerange while building… (authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D72594?vs=237610=237743#toc
kadircet marked 3 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:530
SourceRange S = N.getSourceRange();
+if (auto *TL = N.get()) {
+ // DecltypeTypeLoc only contains the SourceRange for `decltype`
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang-tools-extra/clangd/Selection.cpp:530
SourceRange S = N.getSourceRange();
+if (auto *TL = N.get()) {
+ // DecltypeTypeLoc only
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61742 tests passed, 0 failed
and 780 were skipped.
{icon question-circle color=gray} clang-tidy: unknown.
{icon check-circle color=green} clang-format: pass.
Build artifacts
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Currently AST only contains the location for `decltype` keyword,
therefore we were skipping
