[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet updated this revision to Diff 238244. kadircet marked 3 inline comments as done. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/ https://reviews.llvm.org/D72623 Files:

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

This revision was automatically updated to reflect the committed changes. Closed by commit rG44f9c7a820c1: [clangd] Rearrange type, returntype and parameters in hover card (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet added a comment. In D72623#1819153 , @lh123 wrote: > I think the character "" should be avoided, as it may not display properly > in some environments. I believe most of the editors should be able to display unicode characters, please let us

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

lh123 added a comment. I think the character "" should be avoided, as it may not display properly in some environments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/ https://reviews.llvm.org/D72623

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:567 + } else if (Type) { +Output.addParagraph().appendText("Type: ").appendCode(*Type); } kadircet wrote: > sammccall wrote: > > consider

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:567 + } else if (Type) { +Output.addParagraph().appendText("Type: ").appendCode(*Type); } sammccall wrote: > consider **`∈`**, which would be short and symmetrical with the

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet updated this revision to Diff 237888. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments and rebase on top of ruler patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:552 +// For functions we display signature in a list form, e.g.: +// Generates `x` from: +// - `bool

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Moves type/returntype into its own line as it is more readable in cases where the type is long. Also