[PATCH] D72647: [clangd] Only re-open files if their flags changed

This revision was automatically updated to reflect the committed changes. Closed by commit rG60249c2c3b9e: [clangd] Only re-open files if their flags changed (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman updated this revision to Diff 239907. dgoldman added a comment. - Swap to stringset and simpler way of tracking modified files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D72647 Files:

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman added a comment. In D72647#1833203 , @sammccall wrote: > Let's make the minimal change here and land this. Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/

[PATCH] D72647: [clangd] Only re-open files if their flags changed

sammccall added a comment. Let's make the minimal change here and land this. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1126 + std::set ModifiedFiles; + auto Sub = + CDB->watch([](const std::vector Changes) { dgoldman wrote: > sammccall

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1126 + std::set ModifiedFiles; + auto Sub = + CDB->watch([](const std::vector Changes) { sammccall wrote: > this is a clever technique. (Why not just use

[PATCH] D72647: [clangd] Only re-open files if their flags changed

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1125 // Per-file update to the compilation database. - bool ShouldReparseOpenFiles = false; + std::set ModifiedFiles; + auto Sub = nit: llvm::StringSet<> or DenseSet

[PATCH] D72647: [clangd] Only re-open files if their flags changed

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman updated this revision to Diff 237791. dgoldman added a comment. - Fix broken did-change-configuration test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D72647 Files:

[PATCH] D72647: [clangd] Only re-open files if their flags changed

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61795 tests passed, 1 failed and 781 were skipped. failed: Clangd.Clangd/did-change-configuration-params.test {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green}

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72647 Files: