[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov added a comment. I've pushed the fix already. Is something still broken? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___ cfe-commits mailing list cf

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

thakis added a comment. Things have been broken for 1.5 hours now. Time to revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___ cfe-commits mailing list

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov added a comment. Thanks for reporting this. Somehow I managed to push empty test files. I'll push the fix soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

thakis added a comment. This seems to break check-clang everywhere. If the fix isn't obvious, please revert and analyze asynchronously. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d614a82a423: Summary: This CL adds clang declarations of built-in functions for AMDGPU MFMA… (authored by kpyzhov). Herald added a subscriber: kerbowa. Changed prior to commit: https://reviews.llvm.org

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov added a comment. In D72723#1821917 , @arsenm wrote: > Having two subtarget features for the same feature is an issue ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov updated this revision to Diff 238263. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/Basic/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/builtins-amdgcn-mfma.cl clang/tes

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Having two subtarget features for the same feature is an issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://review

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov updated this revision to Diff 238259. kpyzhov added a reviewer: arsenm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/Basic/Targets/

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 __

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

arsenm added a comment. LGTM Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:487 +def FeatureMfma1Insts : SubtargetFeature<"mfma1-insts", + "HasMfma1Insts", We already have the HasMAIInsts feature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov created this revision. kpyzhov added a reviewer: yaxunl. kpyzhov added a project: AMDGPU. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl, arsenm. Herald added projects: clang, LLVM. Added declarations of MFMA built-