[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn added a comment. In D72778#2080928 , @rjmccall wrote: > Yeah, that's fine. Thank you very much John! I filed https://bugs.llvm.org/show_bug.cgi?id=46251 to keep track of the initializer support, with a note on enabling the commented out test.

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3323a628ec82: [Matrix] Add __builtin_matrix_transpose to Clang. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D72778?vs=269050=269463#toc Repository: rG LLVM Github Monorepo

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall added a comment. Yeah, that's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if (!Arg->getType()->isConstantMatrixType()) { rjmccall wrote: > fhahn wrote: > > rjmccall wrote: > > >

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM with the given testing suggestion. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn marked 4 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if (!Arg->getType()->isConstantMatrixType()) { rjmccall wrote: > fhahn wrote: > > rjmccall wrote: > > >

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn updated this revision to Diff 269050. fhahn added a comment. Simplify code as suggested, use DefaultLValueConversion instead of CheckPlaceholderExpr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if (!Arg->getType()->isConstantMatrixType()) { fhahn wrote: > rjmccall wrote: > > When a builtin has custom type-checking (`t`), you need to

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn updated this revision to Diff 269032. fhahn marked an inline comment as done. fhahn added a comment. Thanks for all the comments! Simplified code as suggested, handle placeholder expressions and add tests for them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1642 + return cast(Ty.getCanonicalType()); +}; + rjmccall wrote: > Unnecessary semicolon. I think it's probably clearer just to > `castAs()`

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1642 + return cast(Ty.getCanonicalType()); +}; + Unnecessary semicolon. I think it's probably clearer just to `castAs()` inline in the code rather than introducing this trivial

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn updated this revision to Diff 268569. fhahn added a comment. Ping. Simplified code and update tests to use more targeted check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778 Files:

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn updated this revision to Diff 263878. fhahn added a comment. ping. Simplify code, extend tests. This should now be ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778 Files:

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72778 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp