pengfei added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3386
+FMulAdd = Builder.CreateConstrainedFPCall(
+CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
+ Addend->getType()),
Allen added inline comments.
Herald added a project: All.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3386
+FMulAdd = Builder.CreateConstrainedFPCall(
+CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
+
pengfei marked an inline comment as done.
pengfei added inline comments.
Comment at: llvm/docs/LangRef.rst:16145
+'``llvm.experimental.constrained.fmuladd``' Intrinsic
+^^^
+
jhenderson wrote:
> This underline
jhenderson added inline comments.
Comment at: llvm/docs/LangRef.rst:16145
+'``llvm.experimental.constrained.fmuladd``' Intrinsic
+^^^
+
This underline isn't long enough and is breaking the sphinx build bot. Please
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3239b5034ee9: [FPEnv] Add pragma FP_CONTRACT support under
strict FP. (authored by pengfei).
Changed prior to commit:
https://reviews.llvm.org/D72820?vs=240474=240840#toc
Repository:
rG LLVM Github
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
pengfei marked an inline comment as done.
pengfei added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381
+ "constrained mode");
+FMulAdd = Builder.CreateCall(
+CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
pengfei updated this revision to Diff 240474.
pengfei added a comment.
Address review comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
Files:
clang/lib/CodeGen/CGExprScalar.cpp
kpn added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381
+ "constrained mode");
+FMulAdd = Builder.CreateCall(
+CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
craig.topper wrote:
> kpn wrote:
>
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381
+ "constrained mode");
+FMulAdd = Builder.CreateCall(
+CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
kpn wrote:
> craig.topper
kpn added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381
+ "constrained mode");
+FMulAdd = Builder.CreateCall(
+CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
craig.topper wrote:
> Doesn't this
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381
+ "constrained mode");
+FMulAdd = Builder.CreateCall(
+CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
Doesn't this need to be
rjmccall added a comment.
Remember that the design is that constrained intrinsics must be used whenever
*any* code in the function is constrained. It is not unreasonable that part of
the function might be constrained and the rest subject to fast-math; it'd be a
shame if the intrinsics
andrew.w.kaylor added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436
+}
+ }
+
cameron.mcinally wrote:
> andrew.w.kaylor wrote:
> > cameron.mcinally wrote:
> > > cameron.mcinally wrote:
> > > > cameron.mcinally wrote:
> > > > > I don't
cameron.mcinally added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436
+}
+ }
+
andrew.w.kaylor wrote:
> cameron.mcinally wrote:
> > cameron.mcinally wrote:
> > > cameron.mcinally wrote:
> > > > I don't think it's safe to fuse a FMUL
pengfei marked an inline comment as done.
pengfei added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381
+ Addend->getType()),
+{MulOp0, MulOp1, Addend, MulOp->getOperand(2), MulOp->getOperand(3)});
+ else
pengfei updated this revision to Diff 238770.
pengfei added a comment.
Remove unnecessary comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
Files:
clang/lib/CodeGen/CGExprScalar.cpp
pengfei updated this revision to Diff 238769.
pengfei marked 7 inline comments as done.
pengfei added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
Files:
andrew.w.kaylor added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436
+}
+ }
+
cameron.mcinally wrote:
> cameron.mcinally wrote:
> > cameron.mcinally wrote:
> > > I don't think it's safe to fuse a FMUL and FADD if the intermediate
> >
cameron.mcinally added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436
+}
+ }
+
cameron.mcinally wrote:
> cameron.mcinally wrote:
> > I don't think it's safe to fuse a FMUL and FADD if the intermediate
> > rounding isn't exactly the
cameron.mcinally added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436
+}
+ }
+
cameron.mcinally wrote:
> I don't think it's safe to fuse a FMUL and FADD if the intermediate rounding
> isn't exactly the same as those individual
cameron.mcinally added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436
+}
+ }
+
I don't think it's safe to fuse a FMUL and FADD if the intermediate rounding
isn't exactly the same as those individual operations. FMULADD doesn't
andrew.w.kaylor added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381
+ Addend->getType()),
+{MulOp0, MulOp1, Addend, MulOp->getOperand(2), MulOp->getOperand(3)});
+ else
You shouldn't just assume that
23 matches
Mail list logo
