[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd541b217f4d: [NewPassManager] Add assertions when getting statefull cached analysis. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea updated this revision to Diff 263590. asbirlea marked 3 inline comments as done. asbirlea added a comment. Address comments. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM other than two nits here, this is really awesome! Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +(*C,

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea added a comment. Weekly re-ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea added a comment. Gentle ping for more comments :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893 ___ cfe-commits mailing list

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea updated this revision to Diff 259450. asbirlea marked 8 inline comments as done. asbirlea added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893 Files:

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea added inline comments. Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +(*C, CG); +ResultFAMCP->updateFAM(FAM); chandlerc wrote: > Check that it doesn't hit an assert failure, but I

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

chandlerc added a comment. Really like the approach now. Pretty minor code nits below only. =D Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +(*C, CG); +ResultFAMCP->updateFAM(FAM); Check

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea updated this revision to Diff 254378. asbirlea added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/