[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper marked 2 inline comments as done. craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12363 +Cmp = Builder.CreateFCmp(Pred, Ops[0], Ops[1]); return EmitX86MaskedCompareResult(*this, Cmp, NumElts, Ops[3]); }

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. lgtm I have a couple of comments, but nothing that couldn't be addressed in a later patch. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12363 +Cmp

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper added a comment. In D72906#1838532 , @uweigand wrote: > In D72906#1837905 , @craig.topper > wrote: > > > In D72906#1826849 , @uweigand > > wrote: > > > > > In

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

uweigand added a comment. In D72906#1837905 , @craig.topper wrote: > In D72906#1826849 , @uweigand wrote: > > > In D72906#1826122 , @craig.topper > > wrote: > > > > > In

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper added a comment. In D72906#1826849 , @uweigand wrote: > In D72906#1826122 , @craig.topper > wrote: > > > In D72906#1826061 , @uweigand > > wrote: > > > > > >

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

uweigand added a comment. In D72906#1826122 , @craig.topper wrote: > In D72906#1826061 , @uweigand wrote: > > > > The constrained fcmp intrinsics don't allow the TRUE/FALSE predicates. > > > > Hmm, maybe they

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper added a comment. In D72906#1826061 , @uweigand wrote: > > The constrained fcmp intrinsics don't allow the TRUE/FALSE predicates. > > Hmm, maybe they should then? The only reason I didn't add them initially > was that I wasn't sure they

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

uweigand added a comment. > The constrained fcmp intrinsics don't allow the TRUE/FALSE predicates. Hmm, maybe they should then? The only reason I didn't add them initially was that I wasn't sure they were useful for anything; if they are, it should be straightforward to add them back.