[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

hans added a comment. In D72911#1900091 , @sylvestre.ledru wrote: > @krasimir @MyDeveloperDay @hans Looks like it is a regression from > https://reviews.llvm.org/D72911 > and the fix isn't in 10.0rc2. > Should we take it? Seems pretty safe. I've

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

sylvestre.ledru added subscribers: hans, sylvestre.ledru. sylvestre.ledru added a comment. @krasimir @MyDeveloperDay @hans Looks like it is a regression from https://reviews.llvm.org/D72911 and the fix isn't in 10.0rc2. Should we take it? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

MyDeveloperDay added a comment. @krasimir Thanks for fixing this, as it looks like I broke it.. its much appreciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG33463cfba2be: clang-format: fix spacing in `operator const char*()` (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238746. krasimir added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238741. krasimir added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir marked 3 inline comments as done. krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2722 +FormatToken *Before = Left.getPreviousNonComment(); +while (Before && Before->isOneOf(tok::kw_const, tok::kw_volatile)) { + Before =

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238743. krasimir added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

mprobst accepted this revision. mprobst added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:2717 +// operator Foo*() +// dependant on PointerAlignment style. + typo dependent

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238738. krasimir added a comment. - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added a reviewer: mprobst. Revision a75f8d98d7ac9e557b238a229a9a2647c71feed1 fixed spacing for operators, but