This revision was automatically updated to reflect the committed changes.
Closed by commit rG8c3e6af71b8e: [WebAssembly] Add experimental multivalue
calling ABI (authored by tlively).
Changed prior to commit:
https://reviews.llvm.org/D72972?vs=238937&id=242511#toc
Repository:
rG LLVM Github
tlively marked 2 inline comments as done.
tlively added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:741
+ explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes &CGT, ABIKind _Kind)
+ : SwiftABIInfo(CGT), defaultInfo(CGT), Kind(_Kind) {}
ahee
aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:741
+ explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes &CGT, ABIKind _Kind)
+ : SwiftABIInfo(CGT), defaultInfo(CGT),
tlively marked 3 inline comments as done.
tlively added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:741
+ explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes &CGT, ABIKind _Kind)
+ : SwiftABIInfo(CGT), defaultInfo(CGT), Kind(_Kind) {}
ahee
aheejin added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:741
+ explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes &CGT, ABIKind _Kind)
+ : SwiftABIInfo(CGT), defaultInfo(CGT), Kind(_Kind) {}
Nit: Do we need `_`?
Commen
merge_guards_bot added a comment.
{icon times-circle color=red} Unit tests: fail. 61974 tests passed, 2 failed
and 783 were skipped.
failed: LLVM.Bindings/Go/go.test
failed:
libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100.
Herald added a project: clang.
For now, this ABI simply expands all possible aggregate arguments and
returns all possible aggregates directly. This AB
