[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

NoQ added a comment. Thank you everybody for unbreaking us! 🙏 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72982/new/ https://reviews.llvm.org/D72982 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. In D72982#1832462 , @aganea wrote: > In D72982#1832233 , @aganea wrote: > > > In D72982#1832209 , @phosek wrote: > > > > > We're seeing `Driver/cc-print

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1832233 , @aganea wrote: > In D72982#1832209 , @phosek wrote: > > > We're seeing `Driver/cc-print-options.c` test failures after this change: > > > Yes, seeing it too, I will commit

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1832209 , @phosek wrote: > We're seeing `Driver/cc-print-options.c` test failures after this change: Yes, seeing it too, I will commit a fix in a minute! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

phosek added a comment. We're seeing `Driver/cc-print-options.c` test failures after this change: TEST 'Clang :: Driver/cc-print-options.c' FAILED Script: -- : 'RUN: at line 1'; env CC_PRINT_OPTIONS=1 CC_PRINT_OPTIONS_FILE=/b/s/w/ir/k/rec

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

NoQ added a comment. In D72982#1832058 , @xazax.hun wrote: > In D72982#1832029 , @aganea wrote: > > > In D72982#1832000 , @xazax.hun > > wrote: > > > > > Thanks! Alternative

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1832029 , @aganea wrote: > In D72982#1832000 , @xazax.hun wrote: > > > Thanks! Alternatively we could try to push the changes to all three > > versions and revert this patch onc

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1832000 , @xazax.hun wrote: > Thanks! Alternatively we could try to push the changes to all three versions > and revert this patch once all of them are accepted and a new pip package is > published. @xazax.hun In that

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1831976 , @hans wrote: > Sigh, what a mess. I totally agree and sorry for that :( >> In case it is printed on a separate line the current parsing happens to work >> in all versions of scan-build and this seemed to b

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. > Due to some unfortunate historical reasons fixing scan-build means fixing 3 > separate code bases. We have the original scan-build written in perl, a > python rewrite both checked-in in the LLVM repository, and on github. And the > two versions are not the same as the au

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1831817 , @hans wrote: > In D72982#1831648 , @xazax.hun wrote: > > > In D72982#1831595 , @hans wrote: > > > > > Wait, do we really want t

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. In D72982#1831648 , @xazax.hun wrote: > In D72982#1831595 , @hans wrote: > > > Wait, do we really want the "(in-process)" marker to be written to a > > separate line? I'm not sure that we do.

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1831595 , @hans wrote: > Wait, do we really want the "(in-process)" marker to be written to a separate > line? I'm not sure that we do. Do you see value in keeping "(in-process)" at all? I added it in the first place f

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1831595 , @hans wrote: > Wait, do we really want the "(in-process)" marker to be written to a separate > line? I'm not sure that we do. Since the `-###` command had this property of emitting copy pastable `-cc1` inv

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. Wait, do we really want the "(in-process)" marker to be written to a separate line? I'm not sure that we do. The change description doesn't explain how scan-build was broken or how this fixes it. And, maybe most importantly, it seems scan-build doesn't have any tests that

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6883017ea9a: [Clang] Un-break scan-build after integrated-cc1 change (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72982/new/ https:/

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. Do you have commit access or need someone to commit on your behalf? Also, in case your change made it into the clang 10 release branch this will need to be cherry picked there as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72982/new/ https://reviews.llvm.org/D72982

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea created this revision. aganea added reviewers: xazax.hun, NoQ, thakis, hans. Herald added subscribers: cfe-commits, Charusso, rnkovacs. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72982 Files: clang/lib/Driver/Job.cpp clang/test/Drive