This revision was automatically updated to reflect the committed changes.
Closed by commit rGeccf7fc7b31a: [AST] Add fixed-point subtraction constant
evaluation. (authored by ebevhan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73185/new/
https:/
ebevhan updated this revision to Diff 255975.
ebevhan added a comment.
Rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73185/new/
https://reviews.llvm.org/D73185
Files:
clang/include/clang/Basic/FixedPoint.h
clang/lib/AST/ExprConstant.c
rjmccall accepted this revision.
rjmccall added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73185/new/
https://reviews.llvm.org/D73185
___
cfe-commits mailing list
cfe-commits@lists.
ebevhan updated this revision to Diff 239791.
ebevhan added a comment.
Move packing of FixedPointSemantics to a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73185/new/
https://reviews.llvm.org/D73185
Files:
clang/include/clang/B
ebevhan marked an inline comment as done.
ebevhan added inline comments.
Comment at: clang/include/clang/Basic/FixedPoint.h:82
+ unsigned IsSaturated: 1;
+ unsigned HasUnsignedPadding : 1;
};
rjmccall wrote:
> These changes should probably be done in a sep
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM other than the request to split the commit.
Comment at: clang/include/clang/Basic/FixedPoint.h:82
+ unsigned IsSaturated: 1;
+ unsigned HasUnsignedPadding : 1;
ebevhan created this revision.
ebevhan added reviewers: rjmccall, leonardchan.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D73185
Files:
clang/include/clang/Basic/FixedPoint.h
clang/lib/AST/ExprConstant
