This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ca2cad947d0: [PowerPC] Add clang -msvr4-struct-return for
32-bit ELF (authored by jhibbits).
Changed prior to commit:
https://reviews.llvm.org/D73290?vs=239982=259143#toc
Repository:
rG LLVM Github
nemanjai accepted this revision.
nemanjai added a comment.
Aside from a couple of minor nits that shouldn't require another review, LGTM.
Comment at: clang/docs/ClangCommandLineReference.rst:2631
+
+Override the default ABI for 32-bit targets to return small structs in
jhibbits added a reviewer: nemanjai.
jhibbits added a comment.
@ZarkoCA I think someone else should also review this, so added @nemanjai as a
potential reviewer. He might have more insight to the code in question. I'd
like to see this go in soon, though, so that it gets into 11, and we can
ZarkoCA added a comment.
@jhibbits is this patch going to be committed soon? I have a patch
(https://reviews.llvm.org/D76360) that I will need to rebase once this is in.
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73290/new/
jhibbits edited reviewers, added: jhibbits; removed: chmeee.
jhibbits accepted this revision.
jhibbits added a comment.
This revision is now accepted and ready to land.
Code looks fine, and others have tested it. Good to see a reversion of the ABI
to expected for GCC compatibility on the BSDs.
brad added a comment.
Now that 10 is out, any chance of getting some movement on this to resolve this
ABI issue with 32-bit PowerPC?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73290/new/
https://reviews.llvm.org/D73290
markmi added a comment.
I built and installed ports, what built vs. did-not was the same as before
applying the update, with the same failure details having nothing to do with
this change. I then ran the FreeBSD kyua tests and the result match what I got
prior to the update.
These tests are
markmi added a comment.
Herald added a subscriber: wuzish.
Summary: My preliminary testing looks good.
FreeBSD does not have clang/test/ and clang/doc/ in its contrib/llvm-project/
so I applied just the other patches to my context and rebuilt my FreeBSD head
-r356426 based context's
kernigh created this revision.
kernigh added reviewers: brad, markmi, chmeee.
kernigh added a project: clang.
Herald added subscribers: cfe-commits, steven.zhang, shchenz, jsji, kbarton,
krytarowski, arichardson, nemanjai, emaste.
This is a patch for https://bugs.llvm.org/show_bug.cgi?id=40736
