[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" davezarzycki wrote: > aaron.ballman wrote: > > davezarzycki wrote: > > > aaron.ballman wr

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" aaron.ballman wrote: > davezarzycki wrote: > > aaron.ballman wrote: > > > davezarzycki wro

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" davezarzycki wrote: > aaron.ballman wrote: > > davezarzycki wrote: > > > aaron.ballman wr

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" aaron.ballman wrote: > davezarzycki wrote: > > aaron.ballman wrote: > > > rnk wrote: > > >

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" davezarzycki wrote: > aaron.ballman wrote: > > rnk wrote: > > > This includes Sema.h into

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" aaron.ballman wrote: > rnk wrote: > > This includes Sema.h into every codegen file that us

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" rnk wrote: > This includes Sema.h into every codegen file that uses CGValue.h (most of >

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

rnk added a comment. I moved this include in rG01943a59f51d8b5ede062305941c1f864b8a6a13 . I meant to paste this in the message, but I'll put it here, since the results were significant: $ diff -u deps-before.txt deps-after.

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

rnk added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" This includes Sema.h into every codegen file that uses CGValue.h (most of them). That seems bad fo

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d61cd25a692: Verify that clang's max alignment is <= LLVM's max alignment (authored by davezarzycki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73363/ne

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. SGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73363/new/ https://reviews.llvm.org/D73363 ___

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki created this revision. davezarzycki added a reviewer: lebedev.ri. davezarzycki added projects: LLVM, clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73363 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGValue.h Index: clang/lib/CodeGen/CGValue