This revision was automatically updated to reflect the committed changes.
Closed by commit rG6874dfce3aef: [clang-tidy] Fix bugprone-use-after-move when
move is in noexcept operator (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62249 tests passed, 0 failed
and 816 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
njames93 updated this revision to Diff 240718.
njames93 added a comment.
- Remove artifacts of old dependent review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73441/new/
https://reviews.llvm.org/D73441
Files:
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62213 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
njames93 updated this revision to Diff 240547.
njames93 added a comment.
- Fix nits in test cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73441/new/
https://reviews.llvm.org/D73441
Files:
gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.
LGTM with fixes to the test.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276
+namespace PR44667 {
+#define REQUIRE(expr)
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62207 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon times-circle color=red} clang-format: fail. Please format your changes
with clang-format by running
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62206 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon times-circle color=red} clang-format: fail. Please format your changes
with clang-format by running
njames93 updated this revision to Diff 240512.
njames93 added a comment.
- Fix formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73441/new/
https://reviews.llvm.org/D73441
Files:
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62207 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon times-circle color=red} clang-format: fail. Please format your changes
with clang-format by running
njames93 updated this revision to Diff 240507.
njames93 added a comment.
- Elide braces
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73441/new/
https://reviews.llvm.org/D73441
Files:
clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
njames93 marked 3 inline comments as done.
njames93 added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276
+namespace PR44667 {
+#define REQUIRE(expr) (void)(expr);
+struct S {};
gribozavr2 wrote:
>
njames93 updated this revision to Diff 240506.
njames93 added a comment.
- added more unevaluated context checks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73441/new/
https://reviews.llvm.org/D73441
Files:
gribozavr2 added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276
+namespace PR44667 {
+#define REQUIRE(expr) (void)(expr);
+struct S {};
njames93 wrote:
> gribozavr2 wrote:
> > Is the macro a necessary
njames93 marked 2 inline comments as done.
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387
+ unless(inDecltypeOrTemplateArg()),
+ unless(hasAncestor(cxxNoexceptExpr(
gribozavr2 added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387
+ unless(inDecltypeOrTemplateArg()),
+ unless(hasAncestor(cxxNoexceptExpr(
.bind("call-move");
Quuxplusone
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
Quuxplusone added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387
+ unless(inDecltypeOrTemplateArg()),
+ unless(hasAncestor(cxxNoexceptExpr(
.bind("call-move");
What about
njames93 created this revision.
njames93 added reviewers: aaron.ballman, alexfh, JonasToth, hokein, gribozavr2.
Herald added subscribers: cfe-commits, xazax.hun.
Herald added a project: clang.
Fixes noexcept operator misinterpreted as being evaluated
19 matches
Mail list logo
